fix: context condensing prompt not saving properly#5634
Merged
kevinvandijk merged 4 commits intoKilo-Org:mainfrom Feb 21, 2026
Merged
fix: context condensing prompt not saving properly#5634kevinvandijk merged 4 commits intoKilo-Org:mainfrom
kevinvandijk merged 4 commits intoKilo-Org:mainfrom
Conversation
Fixes Kilo-Org#5629 - Add local state for condensing prompt to prevent flickering during typing - Initialize local state when switching to CONDENSE tab - Sync with extension state on blur to ensure persistence - Prevent race condition between user input and extension state updates
🦋 Changeset detectedLatest commit: caef0f0 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
jeremylongshore
added a commit
to jeremylongshore/kilocode
that referenced
this pull request
Feb 15, 2026
jeremylongshore
added a commit
to jeremylongshore/kilocode
that referenced
this pull request
Feb 15, 2026
Mirror: fix: context condensing prompt not saving properly (Kilo-Org#5634)
This was referenced Feb 15, 2026
![kilo-code-bot[bot]](https://avatars.githubusercontent.com/in/2193792?s=60&v=4){kind=small}
| if (activeSupportOption === "CONDENSE") { | ||
| setLocalCondensingPrompt(customCondensingPrompt) | ||
| } | ||
| }, [activeSupportOption, customCondensingPrompt]) |
Contributor
There was a problem hiding this comment.
[WARNING]: Including customCondensingPrompt in this dependency array may undermine the anti-flickering protection.
When the user is actively typing, the flow is:
onInput→setLocalCondensingPrompt(value)+updateSupportPrompt(...)→setCustomCondensingPrompt(value)+vscode.postMessage(...)- If the extension processes the message and sends back a different/normalized value (e.g., via
ExtensionStateContext),customCondensingPromptchanges - This
useEffectfires and overwriteslocalCondensingPromptwith the extension's value — exactly the flickering scenario this PR aims to prevent
Consider depending only on activeSupportOption so the local state is initialized only when switching tabs, not overwritten during active editing:
Suggested change
| }, [activeSupportOption, customCondensingPrompt]) | |
| }, [activeSupportOption]) // eslint-disable-line react-hooks/exhaustive-deps |
Alternatively, you could use a ref to track whether the user is actively editing and skip the sync in that case.
Contributor
Code Review SummaryStatus: 1 Issue Found | Recommendation: Address before merge Fix these issues in Kilo Cloud Overview
Issue Details (click to expand)WARNING
Other Observations (not in diff)Issues found in unchanged code or cross-cutting concerns that cannot receive inline comments:
Files Reviewed (2 files)
|
kevinvandijk
approved these changes
Feb 21, 2026
This was referenced Feb 21, 2026
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5629
Problem
Context condensing prompt was clearing out and not saving properly when typing.
Root Cause
The VSCodeTextArea was directly controlled by extension state. Every keystroke triggered a save to extension state → webview re-render → race condition caused text to clear.
Solution
Changes
Testing